[store] Add response hints to label APIs #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
commented
Nov 12, 2020
gouthamve
force-pushed
the
hints-labels-apis
branch
from
b236112
to
69e7faf
Compare
pracucci
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Thanks @gouthamve! LGTM. Could you take a look at the comments, fix tests and rebase master, please?
pracucci
reviewed
Nov 17, 2020
gouthamve
force-pushed
the
hints-labels-apis
branch
3 times, most recently
from
cffb972
to
342db76
Compare
gouthamve
changed the title
|
Fixes #2984 |
bwplotka
approved these changes
Nov 18, 2020
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Fixes thanos-io#2984 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
hints-labels-apis
branch
from
18afd9f
to
a437244
Compare
|
@bwplotka Nice catch, not sure what I was thinking there. Fixed it! |
bwplotka
approved these changes
Nov 18, 2020
2 tasks
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
* Add hints support to labels API responses Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Move to dedicated hints types and add tests Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Add external labels to the values returned in API Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Add changelog entries Fixes thanos-io#2984 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Signed-off-by: Oghenebrume50 <raphlbrume@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In Cortex, we shard blocks b/w store-gateways, hence we need to send the list of blockids to query and the list of ids that have been queried in the response to make sure all the relevant blocks are queried. This has already been done for the
SeriesAPI.I have not yet added request hints yet. I will add them in a subsequent PR.
Verification
tbh, I have not tested it yet. I am only relying on the unit tests. Any tips on how I can test it?